Restrict python version for typing dependency #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing typing causes errors after python 3.6. See python/typing#573 Signed-off-by: Conley Owens <cco3@google.com>
pombredanne
added a commit
to aboutcode-org/scancode-toolkit
that referenced
this pull request
Nov 18, 2020
Applying the same fix here than in aboutcode-org/commoncode#5 Reported-by: Signed-off-by: Conley Owens <cco3@google.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
Hi! Thank you for the fix. When do you plan to publish the new package version to PyPi? Thanks again! |
|
@tiulpin anytime now. This will be in together with a new scancode release by the middle of next week at the latest |
|
Hi! Any news or I missed the update?) |
|
well I was a bit too optimist :) ... we now have a branch in https://github.com/nexB/scancode-toolkit/tree/release-21-01-prep for scancode and I am moving to this here then |
|
@cco3 Thanks. All merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing typing causes errors after python 3.6.
See python/typing#573