Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasClean implementation for reactnative websocket transport #946

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Fix wasClean implementation for reactnative websocket transport #946

merged 1 commit into from
Apr 5, 2022

Conversation

owenpearson
Copy link
Member

@owenpearson owenpearson commented Apr 4, 2022 •
edited
Loading

This was causing reactnative ably-js to assume that every websocket disconnection was unclean.

@owenpearson owenpearson marked this pull request as ready for review April 5, 2022 10:41
@owenpearson owenpearson merged commit b9fa7ff into main Apr 5, 2022
@owenpearson owenpearson deleted the fix-reactnative-websocket-wasClean branch April 5, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter-Maguire Peter-Maguire Peter-Maguire approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenpearson @Peter-Maguire