-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert library code to TypeScript #762
Conversation
2c701b9
to
8b8990e
Compare
Convert lib/types dir to TypeScript
Convert multicaster to typescript
Convert utils.js and defaults.js to typescript
Co-authored-by: Quintin Willison <q@qwuk.net>
Co-authored-by: Quintin Willison <q@qwuk.net>
Co-authored-by: Quintin Willison <q@qwuk.net>
Co-authored-by: Quintin Willison <q@qwuk.net>
fix retry timer setting wrong variable to null (Fixes #898)
Add scripts to run builds for specific platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pretty much skim read thru, given we know that all of this work has already been reviewed once in upstream PRs.
Just a few things that I think could still have a tidy, or I've only just spotted...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic effort! LGTM
Resolves #686
any
type quite widely and there are quite a few explicit type casts). We don't need to keep a note of these since they can easily be identified using ESLint and I do intend to fix them in the near future.ably.min.js
(the minified browser bundle) has increased somewhat (from 193.5kb to 222kb). I don't think there's too much we can do about this right now without a lot of effort/risk, and I think there are better things we can do to reduce bundle size for lib consumers in future (like making the library more compatible with tree shaking).Note for reviewers: All of the changes in this branch have been reviewed independently so don't feel it necessary to read through all of the changes included here; I'm really just looking for more general feedback on the overall structure of what's being changed here (although feel free to comment on specific library code changes if you want).