Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setImmediate if available in browser #757

Merged
merged 1 commit into from
May 28, 2021
Merged

Use setImmediate if available in browser #757

merged 1 commit into from
May 28, 2021

Conversation

owenpearson
Copy link
Member

@owenpearson owenpearson commented May 14, 2021 •
edited
Loading

Resolves #768

Opening as a draft for now just to run this through CI. Resolves an issue with recent versions of chrome throttling chained timers in hidden tabs.

@owenpearson owenpearson marked this pull request as ready for review May 28, 2021 12:03
@owenpearson owenpearson changed the title WIP: Use setImmediate if available in browser Use setImmediate if available in browser May 28, 2021
@owenpearson owenpearson requested a review from ben-xD May 28, 2021 12:03
@owenpearson
Copy link
Member Author

For visibility: the reason this works is that webpack v4 has a polyfill for NodeJS setImmediate. This won't actually use the builtin setImmediate from any browser implementations.

@owenpearson owenpearson merged commit e826e3b into main May 28, 2021
@owenpearson owenpearson deleted the feature/browser-next-tick branch May 28, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-xD ben-xD ben-xD approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain Chrome versions throttling timers in hidden tabs
2 participants
@owenpearson @ben-xD