Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server-sent DETACHED always detach, not fail a channel #313

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Make server-sent DETACHED always detach, not fail a channel #313

merged 1 commit into from
Jul 13, 2016

Conversation

SimonWoolf
Copy link
Member

Lib originally assumed that a DETACHED with an error property should fail the channel

@mattheworiordan
Copy link
Member

Thanks, looks good, we should bump and get this out as soon as possible.

@SimonWoolf SimonWoolf merged commit 6058c3f into master Jul 13, 2016
SimonWoolf added a commit that referenced this pull request Jul 13, 2016
@SimonWoolf
Merge PR #313 'detached'
c639aa4
@SimonWoolf
Copy link
Member Author

released 0.8.28

@paddybyers
Copy link
Member

LGTM, thanks

@SimonWoolf SimonWoolf mentioned this pull request Jul 13, 2016
Closed
@mattheworiordan mattheworiordan deleted the detached branch July 13, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonWoolf @mattheworiordan @paddybyers