Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presence: get clientId from Auth, not options directly #199

Merged
merged 3 commits into from
Jan 20, 2016
Merged

Presence: get clientId from Auth, not options directly #199

merged 3 commits into from
Jan 20, 2016

Conversation

SimonWoolf
Copy link
Member

Fixes #198

@SimonWoolf SimonWoolf mentioned this pull request Jan 13, 2016
Closed
@mattheworiordan
Copy link
Member

LGTM

paddybyers
paddybyers reviewed Jan 14, 2016
View reviewed changes
common/lib/client/realtimepresence.js
@@ -102,7 +104,7 @@ var RealtimePresence = (function() {
};

RealtimePresence.prototype.leave = function(data, callback) {
if(!this.clientId)
if(!getClientId(this))
throw new Error('clientId must have been specified to enter or leave a presence channel');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorInfo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ea53db9

@paddybyers
Copy link
Member

One comment but otherwise lgtm.

Thanks

@paddybyers
Copy link
Member

@SimonWoolf: what happened to this?

@SimonWoolf SimonWoolf merged commit 4e73aee into master Jan 20, 2016
SimonWoolf added a commit that referenced this pull request Jan 20, 2016
@SimonWoolf
Merge PR #199 'presence-clientid'
d9f7061
@SimonWoolf
Copy link
Member Author

Not much, just needed rebasing

@paddybyers
Copy link
Member

Thanks

@SimonWoolf SimonWoolf deleted the presence-clientid branch May 20, 2016 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonWoolf @mattheworiordan @paddybyers