Export EventEmitter so we can use it in other SDKs #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenpearson
approved these changes
Jul 23, 2024
… other SDKs This means the public API doesn't change but we can still make use of EventEmitter without duplicating the code in other SDKs. We'll use this in Chat.
d92c7f6 to
94c1a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make EventEmitter a static field on BaseRealtime so it can be used in other SDKs.
This means the public API doesn't change but we can still make use of EventEmitter without duplicating the code in other SDKs. We'll use this in Chat.
https://ably.atlassian.net/browse/CHA-390
The PR in chat to use this ably/ably-chat-js#304