[SDK-3718] Create tree-shakable MsgPack module
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1dd7667 to
f320e0a
Compare
MsgPack module
MsgPack moduleMsgPack module
00fcf72 to
f320e0a
Compare
8e99076 to
137570a
Compare
f320e0a to
46aa0c9
Compare
46aa0c9 to
dee1c19
Compare
dee1c19 to
6766766
Compare
6766766 to
3a4867d
Compare
7fc3a75 to
3998cdc
Compare
8954827 to
2a59784
Compare
3998cdc to
9efcf0c
Compare
2a59784 to
fd7e1a4
Compare
9efcf0c to
badeeb7
Compare
fd7e1a4 to
63f5524
Compare
The property is already manipulated earlier in this method. Duplication introduced in 4f66064; seems unintentional.
Preparation for #1375 (making MessagePack functionality tree-shakable).
The _MsgPack assignment becomes the only place that Platform.Config.msgpack gets accessed. All other uses now instead access _MsgPack. Preparation for #1375 (making MessagePack functionality tree-shakable).
We move the MessagePack functionality into a tree-shakable MsgPack module. Resolves #1375.
badeeb7 to
f2e425a
Compare
owenpearson
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Looks good!
I wondered for a bit whether it might be simpler to guard optional modules behind a getter like:
get _MsgPack() {
return this._MsgPackModule || Utils.throwMissingModuleError('MsgPack');
}but I guess that would make things complicated when we're passing msgpack into functions like we do in a couple of places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #1419; please review that one first.
This encapsulates the MessagePack functionality in a tree-shakable module. See commit messages for more details.
Resolves #1375.