Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3546] Remove remaining deprecated APIs #1227

Merged
merged 9 commits into from
May 2, 2023
Merged

[SDK-3546] Remove remaining deprecated APIs #1227

merged 9 commits into from
May 2, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Apr 27, 2023 •
edited
Loading

Note: This PR is based on top of #1221. Please review that one first.

This removes the remaining deprecated APIs in the SDK. See commit messages for more details.

Resolves #1197.

@github-actions github-actions bot temporarily deployed to staging/pull/1227/features April 27, 2023 15:58 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the remove-soft-deprecated-apis branch from ff64860 to 36ebc76 Compare April 27, 2023 15:59
@github-actions github-actions bot temporarily deployed to staging/pull/1227/features April 27, 2023 16:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1227/typedoc April 27, 2023 16:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1227/bundle-report April 27, 2023 16:01 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the remove-DeprecatedClientOptions branch from 6778ff0 to fe3c9ce Compare April 27, 2023 17:56
@lawrence-forooghian
Remove deprecated ClientOptions.fallbackHostsUseDefault
adfe599 
Part of #1197.
@lawrence-forooghian
Remove deprecated ability to pass ClientOptions.recover as a boolean
399c896 
Part of #1197.
@lawrence-forooghian
Remove deprecated ability to pass "xhr" in ClientOptions.transports
b8ad229 
Part of #1197.
@lawrence-forooghian
Remove deprecated RealtimePresence.on/off methods
742a981 
Part of #1197.
@lawrence-forooghian
Remove deprecated ability to pass AuthOptions.force property
2402dc2 
Part of #1197.
@lawrence-forooghian
Remove deprecated ability to pass flags to RealtimeChannel.attach
2b56a43 
Part of #1197.
@lawrence-forooghian
Remove deprecated Auth.authorise method
5d3a18a 
Part of #1197.
@lawrence-forooghian
Remove deprecated forms of calling Crypto.getDefaultParams
0f2074e 
Remove the ability to call it without a key, or to pass a key without
wrapping it in a CipherParamOptions object.

Resolves #1197.
@lawrence-forooghian
Remove Logger.deprecated* methods
2335432 
No longer used as of 0f2074e.
@lawrence-forooghian lawrence-forooghian force-pushed the remove-soft-deprecated-apis branch from 36ebc76 to 2335432 Compare April 27, 2023 17:56
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review April 27, 2023 18:38
owenpearson
owenpearson approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work :)

Base automatically changed from remove-DeprecatedClientOptions to integration/v2 May 2, 2023 12:19
@lawrence-forooghian lawrence-forooghian merged commit 21135f7 into integration/v2 May 2, 2023
@lawrence-forooghian lawrence-forooghian deleted the remove-soft-deprecated-apis branch May 2, 2023 12:19
@lawrence-forooghian lawrence-forooghian mentioned this pull request May 2, 2023
Closed
@hayleynewton hayleynewton changed the title Remove remaining deprecated APIs [SDK-3546] Remove remaining deprecated APIs Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@Peter-Maguire Peter-Maguire Awaiting requested review from Peter-Maguire

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawrence-forooghian @owenpearson