Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fetch as fallback if XHR and JSONP unsupported #1019

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Implement fetch as fallback if XHR and JSONP unsupported #1019

merged 11 commits into from
Nov 8, 2022

Conversation

owenpearson
Copy link
Member

@owenpearson owenpearson commented Jul 1, 2022 •
edited by Peter-Maguire
Loading

Work in progress. Should resolve #766 and make the webworker bundle compatible with service workers.

Still need to:

  • Improve error handling and logging
  • Come up with a way to test this in CI (while still running the tests with XHRRequest)
  • Fix the checkPatch test which is failing due to some echoserver CORS nonsense
  • Add an error log for when a client has no available method to send HTTP requests (currently this causes confusing behaviour when ably-js is used in platforms with no XMLHttpRequest)

@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 1, 2022 16:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 3, 2022 22:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 3, 2022 22:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 4, 2022 00:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 4, 2022 00:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 4, 2022 01:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 4, 2022 01:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 4, 2022 02:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report July 4, 2022 02:14 Inactive
@Peter-Maguire Peter-Maguire self-assigned this Nov 1, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report November 4, 2022 13:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/typedoc November 4, 2022 13:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/bundle-report November 4, 2022 16:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1019/typedoc November 4, 2022 16:29 Inactive
@Peter-Maguire Peter-Maguire marked this pull request as ready for review November 7, 2022 11:23
owenpearson
owenpearson commented Nov 7, 2022
View reviewed changes
test/browser/http.test.js Outdated Show resolved Hide resolved
test/browser/http.test.js Outdated Show resolved Hide resolved
@owenpearson
Copy link
Member Author

LGTM

Peter-Maguire
Peter-Maguire approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@Peter-Maguire Peter-Maguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Approving on Owen's behalf, as he can't approve since he authored the PR)

@Peter-Maguire Peter-Maguire merged commit 78a349b into main Nov 8, 2022
@Peter-Maguire Peter-Maguire deleted the fetch-request branch November 8, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 left review comments

@Peter-Maguire Peter-Maguire Peter-Maguire approved these changes

Assignees

@Peter-Maguire Peter-Maguire

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Cloudflare worker support
3 participants
@owenpearson @Peter-Maguire @sacOO7