Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service worker fix #1016

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Service worker fix #1016

merged 3 commits into from
Jun 30, 2022

Conversation

owenpearson
Copy link
Member

Resolves #1013

@owenpearson
Add helper util for global object fallbacks
6d8029c
@owenpearson
Use helper util for global object
624cffc 
This makes the library use `self` when `global` and `window` are
undefined, fixing a compatibility issue with some service worker
contexts.
@github-actions github-actions bot temporarily deployed to staging/pull/1016/bundle-report June 29, 2022 11:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1016/bundle-report June 29, 2022 13:20 Inactive
@owenpearson owenpearson marked this pull request as ready for review June 29, 2022 15:39
@owenpearson owenpearson merged commit 4c03991 into main Jun 30, 2022
@owenpearson owenpearson deleted the service-worker-fix branch June 30, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter-Maguire Peter-Maguire Peter-Maguire approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: window is not defined when initialising Realtime in a Service Worker
2 participants
@owenpearson @Peter-Maguire