Merge pull request #1129 from ably/errorinfo-extends-error

fix: `ErrorInfo` extends `Error`
ably · Feb 27, 2023 · 279488a · 279488a
2 parents 5854ecd + 59aca8c
commit 279488a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/common/lib/client/realtimechannel.ts b/src/common/lib/client/realtimechannel.ts
@@ -114,11 +114,7 @@ class RealtimeChannel extends Channel {
   }
 
   static invalidStateError(state: string): ErrorInfo {
-    return {
-      statusCode: 400,
-      code: 90001,
-      message: 'Channel operation failed as channel state is ' + state,
-    };
+    return new ErrorInfo('Channel operation failed as channel state is ' + state, 90001, 400);
   }
 
   static processListenerArgs(args: unknown[]): any[] {

diff --git a/src/common/lib/types/errorinfo.ts b/src/common/lib/types/errorinfo.ts
@@ -1,15 +1,17 @@
 import Platform from 'common/platform';
 import * as Utils from '../util/utils';
 
-export default class ErrorInfo {
-  message: string;
+export default class ErrorInfo extends Error {
   code: number | null;
   statusCode?: number;
   cause?: string | Error | ErrorInfo;
   href?: string;
 
   constructor(message: string, code: number | null, statusCode?: number, cause?: string | Error | ErrorInfo) {
-    this.message = message;
+    super(message);
+    if (typeof Object.setPrototypeOf !== 'undefined') {
+      Object.setPrototypeOf(this, ErrorInfo.prototype);
+    }
     this.code = code;
     this.statusCode = statusCode;
     this.cause = cause;