fix: persist kubernetes config #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiosoft
reviewed
Dec 13, 2022
abiosoft
previously approved these changes
Dec 13, 2022
This reverts commit 9c20e4a.
10916de to
384da14
Compare
|
I want to re-trigger the workflow by force-push since the previous one failed. https://github.com/abiosoft/colima/actions/runs/3686095318 |
abiosoft
approved these changes
Dec 14, 2022
|
I am so sorry that there is still one failing CI check. I have to bother you to trigger it again. @abiosoft |
no worries, it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL; DR
This PR fixes an issue that the traefik component is still launched even it is disabled by default in the
colima.yamlconfig.Issue Description
On starting colima with kubernetes disabled, the kubernetes config is not persisted to the filesystem of the guest OS. Later we start the kubernetes and it failed to load the kubernetes config. As a side effect, it still launches the traefik component even it is disabled by default.
Solution
- Add traefik to the default disabled component list