Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kubernetes-disable flag #443

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

pmalek
Copy link
Contributor

@pmalek pmalek commented Oct 13, 2022

This PR adds a generic --kubernetes-disable flag which accepts a slice of names of packaged k3s components to disable.

Full list of those can be obtained by looking at the flags for k3s server:

   --disable value                            (components) Do not deploy packaged components and delete any deployed components (valid items: coredns, servicelb, traefik, local-storage, metrics-server)

@abiosoft
Copy link
Owner

Thanks for this. Other than minor rewording of the flag doc, I think it's good to go.

Co-authored-by: Abiola Ibrahim <git@abiosoft.com>
@pmalek
Copy link
Contributor Author

pmalek commented Oct 13, 2022

Updated the flag description, PTAL.

@pmalek pmalek requested a review from abiosoft October 13, 2022 11:34
@abiosoft abiosoft merged commit 6805660 into abiosoft:main Oct 13, 2022
@ventsislav-georgiev
Copy link

Doesn't this change the defaults, now having traefik enabled?

@pmalek
Copy link
Contributor Author

pmalek commented Oct 13, 2022

@ventsislav-georgiev It does. We'd have to add traefik to the default slice to retain the backwards compatibility (of some sorts). Is that something we'd like to do?

@ventsislav-georgiev
Copy link

Well it depends. I am using nginx and having traefik disabled is useful to me. Changing the defaults results in unexpected extra component in my cluster after minor update. However, colima is in alpha version (semver 0.x.x). So breaking changes can be expected at every release. Just wanted to know if it is noted, desired change.

@abiosoft
Copy link
Owner

abiosoft commented Oct 14, 2022

@ventsislav-georgiev that's a good point. I am in favour of maintaining backward compatibility when it's easy to do (like this case). Traefik will be disabled by default in a follow-up PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants