Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set a REVIEWERS_UNMODIFIED_EXIT_CODE, avoiding parallel action cancellation #4

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

mcpengelly
Copy link
Contributor

setting a REVIEWERS_UNMODIFIED_EXIT_CODE will allow consumers of this github action to set an exit status (my use case: exit code 0), this can be useful for preventing cancellation of parallel github actions if the assignee-to-reviewer action is skipped/not needed.

@abinoda
Copy link
Owner

abinoda commented Jun 17, 2019

@mcpengelly Thanks for this and the write up at #3! Any reason not to just hardcode a different exit code (not 78)?

@abinoda
Copy link
Owner

abinoda commented Jun 17, 2019

@mcpengelly Actually I understand better now... this makes sense and looks good!

@abinoda abinoda merged commit 3e8e4c7 into abinoda:master Jun 17, 2019
@mcpengelly
Copy link
Contributor Author

mcpengelly commented Jun 17, 2019

Mostly just for maintainability in the future (in case github changes anything), also can document it better this way in the README. I left the default behaviour of the action the same. but the user can specify their own if they'd like some other exit code. I referenced this other action which had the same functionality: https://github.com/jessfraz/branch-cleanup-action

I should note i havent actually had a chance to test it out yet because the response was so quick. Will be testing shortly.

Tested: works for my usecase. Thanks for the quick response!

@mcpengelly mcpengelly deleted the prevent-cancelling-other-workflows branch June 17, 2019 15:12
@mcpengelly mcpengelly restored the prevent-cancelling-other-workflows branch June 17, 2019 15:16
@mcpengelly mcpengelly deleted the prevent-cancelling-other-workflows branch June 17, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants