Skip to content

Commit

Permalink
Fix key error in cloudtrail module (ansible-collections#1088)
Browse files Browse the repository at this point in the history
Fix key error in cloudtrail module

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


The PR fixes
"msg": "Failed to create Trail: Parameter validation failed:\nUnknown parameter in input: \"TagList\", must be one of: Name, S3BucketName, S3KeyPrefix, SnsTopicName, IncludeGlobalServiceEvents, IsMultiRegionTrail, EnableLogFileValidation, CloudWatchLogsLogGroupArn, CloudWatchLogsRoleArn, KmsKeyId, IsOrganizationTrail, TagsList"
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

cloudtrail.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
  • Loading branch information
GomathiselviS authored Sep 29, 2022
1 parent 156f977 commit e929cf6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- cloudtrail - Fix key error TagList to TagsList (https://github.com/ansible-collections/amazon.aws/issues/1088).
2 changes: 1 addition & 1 deletion plugins/modules/cloudtrail.py
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ def main():
results['exists'] = True
if not module.check_mode:
if tags:
ct_params['TagList'] = ansible_dict_to_boto3_tag_list(tags)
ct_params['TagsList'] = ansible_dict_to_boto3_tag_list(tags)
# If we aren't in check_mode then actually create it
created_trail = create_trail(module, client, ct_params)
# Get the trail status
Expand Down

0 comments on commit e929cf6

Please sign in to comment.