Don't consider prop 'StateTransitionedTimestamp' in change detection (a…

…nsible-collections#1440) Don't consider prop 'StateTransitionedTimestamp' in change detection SUMMARY Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated. Fixes ansible-collections#1439 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudwatch-metric-alarm ADDITIONAL INFORMATION See issue ansible-collections#1439 for additional details. Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
abikouo · Mar 28, 2023 · 8acb076 · 8acb076
1 parent 419b2cc
commit 8acb076
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/changelogs/fragments/1440-cloudwatch_metric_alarm-fix-change-detection.yml b/changelogs/fragments/1440-cloudwatch_metric_alarm-fix-change-detection.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- cloudwatch_metric_alarm - Don't consider ``StateTransitionedTimestamp`` in change detection. (https://github.com/ansible-collections/amazon.aws/pull/1440).
diff --git a/plugins/modules/cloudwatch_metric_alarm.py b/plugins/modules/cloudwatch_metric_alarm.py
@@ -333,8 +333,10 @@ def create_metric_alarm(connection, module, params):
         if 'TreatMissingData' not in alarm.keys():
             alarm['TreatMissingData'] = 'missing'
 
+        # Exclude certain props from change detection
         for key in ['ActionsEnabled', 'StateValue', 'StateReason',
                     'StateReasonData', 'StateUpdatedTimestamp',
+                    'StateTransitionedTimestamp',
                     'AlarmArn', 'AlarmConfigurationUpdatedTimestamp', 'Metrics']:
             alarm.pop(key, None)
         if alarm != params:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- cloudwatch_metric_alarm - Don't consider ``StateTransitionedTimestamp`` in change detection. (https://github.com/ansible-collections/amazon.aws/pull/1440).