Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add a "made using ggshakeR" to all plots #110

Closed
abhiamishra opened this issue Aug 15, 2022 · 6 comments
Closed

[Feature Request]: Add a "made using ggshakeR" to all plots #110

abhiamishra opened this issue Aug 15, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@abhiamishra
Copy link
Owner

Suggest an idea or something that can be improved.

As the title says

@abhiamishra abhiamishra added the enhancement New feature or request label Aug 15, 2022
@abhiamishra
Copy link
Owner Author

@rithwikrajendran can you pick up some of these plots?

Look at @harshkrishna17's plot_pizza to find that we only need to add caption ggplot element to our plots.

@rithwikrajendran
Copy link
Contributor

@rithwikrajendran can you pick up some of these plots?

Look at @harshkrishna17's plot_pizza to find that we only need to add caption ggplot element to our plots.

Yes, I would be fine picking up some of the plots. But I haven't understood the issue/requirement yet. Can you explain it a bit?

@abhiamishra
Copy link
Owner Author

Basically add a caption to plots so that anytime anyone uses ggshakeR, the plots made by us can be identified by a caption.

Allows our package to be more easily found.

Think of it like as a "Made by Rithwik" on a scatterplot, etc

@rithwikrajendran
Copy link
Contributor

Got it. I'll work on it soon.

@abhiamishra
Copy link
Owner Author

@rithwikrajendran I'm using this as caption:

"Created using ggshakeR"

@rithwikrajendran
Copy link
Contributor

@rithwikrajendran I'm using this as caption:

"Created using ggshakeR"

Got it!

abhiamishra added a commit that referenced this issue Aug 21, 2022
- Closes #111 by fixing plot_pass, plot_heatmap, and plot_passflow orientation + plotting problems
- Works on #110 by adding "Created using ggshakeR" to the above plots.
@abhiamishra abhiamishra mentioned this issue Aug 27, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants