Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external puffin viewer instead of integrating puffin_egui #143

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jun 15, 2024

Previously, we used the integrated puffin_egui as profiler UI. The advantage is that installing puffin_viewer wasn't necessary, but it means that we're stuck to whatever egui version puffin_egui is using, which is very annoying. This PR migrates to using puffin_http and the external puffin_viewer to lift this limitation.

Use cargo install puffin_viewer --locked to use the profiling feature.

@abey79 abey79 added common Relates to multiple crates dependencies Change/update dependencies labels Jun 15, 2024
@abey79 abey79 merged commit 88fe1f2 into master Jun 15, 2024
11 of 12 checks passed
@abey79 abey79 deleted the puffin-http branch June 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Relates to multiple crates dependencies Change/update dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant