Support multiple chat templates - step 1 #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a first step, allow user to to select template from metadata with chat_format parameter in the form of `chat_template.name`.
|
@CISC thank you I'll review this weekend! |
|
@CISC sorry for the delay in reviewing, one thought I had is that I'm a little nervous about registering these templates globally on model load, this seems like a side-effect that will cause some headaches if users are unaware. |
|
Sure, I get that, it also just occurred to me that this will wreak havoc if a user loads more than one model with chat template metadata. :( Maybe register it per-model somehow? |
|
@abetlen How about this? Does not clobber global registry, but still easily accessible for run-time switch. |
|
@CISC perfect, I did update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards #1336, allow user to to select template from metadata with chat_format parameter in the form of
chat_template.name.