Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As an user, I want to see navs #2

Closed
2 tasks done
abemscac opened this issue Apr 21, 2022 · 4 comments · Fixed by #11
Closed
2 tasks done

As an user, I want to see navs #2

abemscac opened this issue Apr 21, 2022 · 4 comments · Fixed by #11
Labels
feature New pages or functionalities

Comments

@abemscac
Copy link
Owner

abemscac commented Apr 21, 2022 •
edited
Loading

身為一個使用者，我想要看到上方和左方的選單

Screen Shot 2022-04-21 at 9 01 52 AM

備註：
這是一個feature，他底下會有多個implementation-story
真正可以被實踐的東西是implementation-story，feature是他們的parent，主要是用來描述這個大功能的全貌，然後追蹤底下的issue
例如說要造一輛車我們會需要方向盤、輪胎、引擎等等
「造車子」就會是一個feature，實作輪胎、實作方向盤、實作引擎就會是implementation-story
所以我們不會有2-navs這樣的branch，因為feature是抽象的，真正有實體的東西是他底下的那些implementation-story
正常的結構會是epic -> feature -> implementation-story
但是我們的功能小，epic對我們來說太大了，所以feature就夠了
@abemscac abemscac added the implementation-story Things to be implemented label Apr 21, 2022
@abemscac abemscac changed the title Navs for guest Navs for guests Apr 21, 2022
@abemscac abemscac changed the title Navs for guests Navs epic Apr 22, 2022
@abemscac abemscac added feature New pages or functionalities and removed implementation-story Things to be implemented labels Apr 22, 2022
@abemscac abemscac changed the title Navs epic Navs Apr 23, 2022
@abemscac abemscac added implementation-story Things to be implemented feature New pages or functionalities and removed feature New pages or functionalities implementation-story Things to be implemented labels Apr 23, 2022
@abemscac abemscac changed the title Navs As an user, I want to see navs in the app Apr 25, 2022
@abemscac abemscac changed the title As an user, I want to see navs in the app As an user, I want to see navs Apr 25, 2022
@abemscac
Copy link
Owner Author

abemscac commented Apr 26, 2022 •
edited
Loading

@meow0516 yo阿姨
您下一個要做的issue會4這e格，會開始有style的出現
您想要用哪一種style都可以，scss/postcss(跟scss差不多)/utility-first css(tailwind或primeflex這種的)/styled-component或是其他怪css
您可以挑一個中意的或想學的來用
因為INET有自己的元件設計，所以BootstrapVue這種整套的UI library就不適合我們
您得從頭動手做一個出來，484很棒

另外共用元件也會開始出現，例如navbar上面的input
但是您不見得要馬上把它做成共用的component
因為他現在只有出現一次，所以您可以直接把它寫在navbar裡面
我們永遠可以藉由重構程式碼來把那些東西從非共用轉成共用
我發現這樣的開發速度會快一些，不會過度設計/過度思考
就算您知道這個input最後會需要5個props，但是現在只用到2個
可以只做用到的那2個就好，另外3個等真正用到了再來refactor，會讓事情變得比較簡單
不過這只是建議，如果這些東西對您來說其實挺容易的那也可以一次把它做完，完全沒問題

@abemscac
Copy link
Owner Author

關於一些github workflow branch的管理知識，供您參考

您可以隨意刪除自己在remote建立的branch，Sourcetree的話刪除的時候要勾Force delete+Delete remote branch
只要確定其他人沒有在用那個branch就好
因為通常implementation story會拆成很小，一次由一個人負責
所以其他人通常不會碰到您建立的branch，除非您把那個issue它交給其他人接手

有人習慣在功能還沒開發完成前把branch取叫1-create-project-wip或是1-create-project-2
等功能做完之後再推真正的1-create-project到remote，最後把那個暫時的-wip或是-2從remote刪掉
看您自己喜歡哪一種，大原則就是您自己建立的branch要怎麼搞都可以，不會有問題

@abemscac
Copy link
Owner Author

abemscac commented May 2, 2022

@meow0516 yo阿姨
Patrick哥說他照著這篇的做 typicode/husky#390 (comment) 之後有成功解決搜死tree跟husky沒辦法一起用的問題
我沒試過，但是供您參考

@meow0516
Copy link
Collaborator

meow0516 commented May 2, 2022

Y，哈士奇和樹目前看起來能和平相處了

@abemscac abemscac mentioned this issue May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New pages or functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: nav for guests abemscac/inet-meow0516
2 participants
@abemscac @meow0516