🐛 Fix undefined appearing after a commit link

When a commit does not have a closes expression, `undefined` was appearing next to the commit link.
abe33 · May 28, 2014 · 879d060 · 879d060
1 parent a5a18bd
commit 879d060
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/bin/changelog b/bin/changelog
@@ -427,6 +427,8 @@ get_commit_closes = function(commit) {
   closes = commit.closes.map(link_to_issue).join(', ');
   if (closes.length > 0) {
     return ", " + closes;
+  } else {
+    return '';
   }
 };
 

diff --git a/src/markdown_utils.coffee b/src/markdown_utils.coffee
@@ -91,7 +91,10 @@ get_commit_body = (commit, section_config) ->
 
 get_commit_closes = (commit) ->
   closes = commit.closes.map(link_to_issue).join(', ')
-  ", #{closes}" if closes.length > 0
+  if closes.length > 0
+    ", #{closes}"
+  else
+    ''
 
 get_commit_output = (commit, section_config) ->
   closes = get_commit_closes(commit)