Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.1 Upgrade #105

Merged
merged 22 commits into from
Nov 18, 2022
Merged

3.0.1 Upgrade #105

merged 22 commits into from
Nov 18, 2022

Conversation

miguelmtzinf
Copy link
Collaborator

No description provided.

@sakulstra
Copy link
Contributor

@miguelmtzinf should i also bump revision here? (in the end ended up copying the code as i needed to alter initialize function on the upgrade)

@miguelmtzinf
Copy link
Collaborator Author

@miguelmtzinf should i also bump revision here? (in the end ended up copying the code as i needed to alter initialize function on the upgrade)

Yeah! lets bump the revision on a separate PR

@sakulstra
Copy link
Contributor

@miguelmtzinf #107

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Base: 56.14% // Head: 56.14% // No change to project coverage 👍

Coverage data is based on head (6d8799c) compared to base (a905aa9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   56.14%   56.14%           
=======================================
  Files          25       25           
  Lines         976      976           
  Branches      123      123           
=======================================
  Hits          548      548           
  Misses        428      428           
Impacted Files Coverage Δ
...ontracts/adapters/paraswap/BaseParaSwapAdapter.sol 90.00% <ø> (ø)
...racts/adapters/paraswap/BaseParaSwapBuyAdapter.sol 96.77% <ø> (ø)
...acts/adapters/paraswap/BaseParaSwapSellAdapter.sol 100.00% <ø> (ø)
...adapters/paraswap/ParaSwapLiquiditySwapAdapter.sol 100.00% <ø> (ø)
...ntracts/adapters/paraswap/ParaSwapRepayAdapter.sol 100.00% <ø> (ø)
...acts/dependencies/openzeppelin/ReentrancyGuard.sol 100.00% <ø> (ø)
contracts/libraries/DataTypesHelper.sol 100.00% <ø> (ø)
contracts/misc/UiIncentiveDataProviderV3.sol 0.00% <ø> (ø)
contracts/misc/UiPoolDataProviderV3.sol 0.00% <ø> (ø)
contracts/misc/WrappedTokenGatewayV3.sol 75.92% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miguelmtzinf miguelmtzinf merged commit 9a36969 into master Nov 18, 2022
@sakulstra
Copy link
Contributor

sakulstra commented Nov 18, 2022

The recap of what's included here:

  1. soften solidity versions to ^0.8.0 feat: soften version requirements #102
  2. adding a getter to fetch the current index feat: add getter for current index on rewardsController #101
  3. replacing totalSupply with totalScaledSupply on setEmissionPerSecond fix: use scaled total supply #104
  4. pumping revision from 1 to 2 feat: bump revision #107
  5. fixing getUserReward to return correct rewards for users with 0 balance Fix getUserRewards getter #112
  6. remove unnecessary constructor that sets state on a contract always used behind a proxy Fix/117 Remove constructor of RewardsDistributor and RewardsController #118
  7. consistently uppercase license pragma agpl->AGPL chore: uppercase license pragma #120
  8. improving documentation on various structs docs: Add docs to Rewards structs #121

@miguelmtzinf miguelmtzinf changed the title Feat/3.0.1 3.0.1 Upgrade Jan 10, 2023
TobaSenju pushed a commit to TobaSenju/mahalend-contracts-periphery that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants