Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This is binary breaking change !!
To reduce memory allocations and improve scanning speed (less GC) I've changed
Mark
to be a read-only struct. In parsing test code profiling showed that over 20% of memory allocations were from constructingMark
instances. This is a binary breaking change, but I'd argue the performance benefits are quite good. The API itself didn't changeUsing
in
modifier passingMark
instances around as struct size exceeds pointer size.Also introduced
ThrowHelper
to allow inliningMark
constructor.Benchmark Code
Uses the large YAML from issue #519 . I noticed you don't have a benchmark project currently so I'm running my local one.
Results
YamlStreamBenchmark