Fix for the case no min. and only max. repetition #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mistakenly omitted to mark a maximum repetition without an exactly specified minimum, and represented it as an exact repetition. The bug was revealed on tests with BCP47.
Merged
mristin
added a commit
that referenced
this pull request
Mar 22, 2024
mristin
added a commit
to aas-core-works/aas-core-codegen
that referenced
this pull request
Mar 22, 2024
We update the development requirements to and re-record the test data for [aas-core-meta cb28d18]. We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core-codegen
that referenced
this pull request
Mar 22, 2024
We update the development requirements to and re-record the test data for [aas-core-meta cb28d18]. We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-testgen
that referenced
this pull request
Mar 22, 2024
We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], and * [aas-core-codegen c414f32]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-testgen
that referenced
this pull request
Mar 22, 2024
We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], and * [aas-core-codegen c414f32]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-python
that referenced
this pull request
Mar 22, 2024
…#23) We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-golang
that referenced
this pull request
Mar 23, 2024
We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-golang
that referenced
this pull request
Mar 23, 2024
…#17) We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-typescript
that referenced
this pull request
Mar 23, 2024
We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-csharp
that referenced
this pull request
Mar 23, 2024
We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-typescript
that referenced
this pull request
Mar 23, 2024
…#23) We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-csharp
that referenced
this pull request
Mar 23, 2024
…#31) We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-cpp
that referenced
this pull request
Mar 23, 2024
We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
mristin
added a commit
to aas-core-works/aas-core3.0-cpp
that referenced
this pull request
Mar 23, 2024
…#37) We update the development requirements to and re-generate everything with: * [aas-core-meta cb28d18], * [aas-core-codegen c414f32] and * [aas-core3.0-testgen 6ff39c260]. [aas-core-meta cb28d18]: aas-core-works/aas-core-meta@cb28d18 [aas-core-codegen c414f32]: aas-core-works/aas-core-codegen@c414f32 [aas-core3.0-testgen 6ff39c260]: aas-core-works/aas-core3.0-testgen@6ff39c260 We propagate [the fix from abnf-to-regex] related to maximum qualifiers which had been mistakenly represented as exact repetition before. [the fix from abnf-to-regex]: aas-core-works/abnf-to-regexp#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mistakenly omitted to mark a maximum repetition without an exactly specified minimum, and represented it as an exact repetition.
The bug was revealed on tests with BCP47.