Test and fix for text attached to end XML elements #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ElementTree's `XMLPullParser` sometimes attaches the text to the start element and sometimes to the end element. We could not figure out why there is a different behavior, but suspect that it has something to do with the size of the parser buffer. In this patch, we fix by looking for text in both events (start as well as end element). This is related to the issue #17, and based on the aas-core-codegen after the pull request aas-core-works/aas-core-codegen#443 has been merged in, [aas-core-codegen 330f391]. [aas-core-codegen 330f391]: aas-core-works/aas-core-codegen@330f391
mristin
added a commit
that referenced
this pull request
Feb 14, 2024
* Test and fix for text attached to end XML elements (#18). This patch fixes for the edge case where ElementTree's ```XMLPullParser`` attaches the text to the end element instead of the start element. Previously, some XML files were wrongly reported as incorrect. We do not know what causes this different behavior of the parser, but suspect that it has something to do with the size of the parser's buffer.
Merged
mristin
added a commit
that referenced
this pull request
Feb 14, 2024
* Test and fix for text attached to end XML elements (#18). This patch fixes for the edge case where ElementTree's ```XMLPullParser`` attaches the text to the end element instead of the start element. Previously, some XML files were wrongly reported as incorrect. We do not know what causes this different behavior of the parser, but suspect that it has something to do with the size of the parser's buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ElementTree's
XMLPullParsersometimes attaches the text to the start element and sometimes to the end element. We could not figure out why there is a different behavior, but suspect that it has something to do with the size of the parser buffer.In this patch, we fix by looking for text in both events (start as well as end element).
This is related to the issue #17, and based on the aas-core-codegen after the pull request
aas-core-works/aas-core-codegen#443 has been merged in, aas-core-codegen 330f391.