Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions script #141

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update GitHub Actions script #141

merged 3 commits into from
Dec 18, 2023

Conversation

MisterDA
Copy link
Contributor

  • Always use latest patch release
  • Add OCaml 5.0 and 4.14
  • Update to actions/checkout@v3

Subsumes #137.

- use latest 4.14 branch;
- add OCaml 5.0;
- update to actions/checkout@v3;
- use opam-repository-mingw#sunset and opam-repository on Windows.
@MisterDA
Copy link
Contributor Author

MisterDA commented Apr 4, 2023

I've rebased this branch and added opam-repository-mingw#sunset on Windows.

@aantron
Copy link
Owner

aantron commented Apr 4, 2023

Thank you. Immediately before you rebased this branch, I had already merged master into it (see the commit history) and was about to squash this back into master. When you force-push, please use --force-with-lease. I'll see about what to do now -- please don't force-push in the meantime :)

@aantron
Copy link
Owner

aantron commented Apr 4, 2023

Could you comment on why you added opam-repository-mingw#sunset? FYI the last build on Windows, in this PR but without the repo, succeeded.

@MisterDA
Copy link
Contributor Author

MisterDA commented Apr 5, 2023

Sorry about the force-push. I had forgotten about that PR, the renewed activity was an incentive to update it as I would do now.
The fdopen/opam-repository-mingw was deprecated and isn't receiving any updates. The ocaml-opam/opam-repository-mingw#sunset branch has been augmented with

  • OCaml 4.14.1 packages, in the same style as the 4.14.0 forked packages (the “pre-compiled” package variants exist, but they’re not pre-compiled);
  • Changes to the constraints for existing packages only.
    It is also recommended to use it as the default repository, and fallback to ocaml/opam-repository for newer packages.
    See Sunsetting opam-repository-mingw.

@aantron
Copy link
Owner

aantron commented Apr 5, 2023

Thanks, I will look into that!

What do you mean by that this PR subsumes #137?

@MisterDA
Copy link
Contributor Author

MisterDA commented Apr 5, 2023

What do you mean by that this PR subsumes #137?

It was probably a bad choice of words.
This PR just replaces parts of #137 that were updating the GitHub Actions script. IIRC this PR and #139 completely replace #137.

@aantron aantron merged commit 5f3731e into aantron:master Dec 18, 2023
3 of 8 checks passed
@aantron
Copy link
Owner

aantron commented Dec 18, 2023

Thank you and sorry about the delay!

@MisterDA MisterDA deleted the gha branch December 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants