Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for missing alt attribute on <map> and <area> tags. #5

Merged
merged 1 commit into from
Mar 17, 2024
Merged

add validation for missing alt attribute on <map> and <area> tags. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RULES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ List of [WCAG2.1 techniques](https://www.w3.org/TR/WCAG21/) and whether or not w
| -------------------------------------------------- | ---------------------------------------------------------------------------- | ----- | ----- | --------------- | -------- |
| [G18](https://www.w3.org/TR/WCAG20-TECHS/G18.html) | element has insufficient contrast at this conformance level | AAA | error | | |
| [H2](https://www.w3.org/TR/WCAG20-TECHS/H2.html) | img element in link has alt text that duplicates the text content of link | A-AAA | error | EG | ✅ |
| [H24](https://www.w3.org/TR/WCAG20-TECHS/H24.html) | Image map and areas must have alt texts. | A-AAA | error | ImageMapNoAlt | ✅
| [H25](https://www.w3.org/TR/WCAG20-TECHS/H25.html) | empty titles | A-AAA | error | | ✅ |
| [H30](https://www.w3.org/TR/WCAG20-TECHS/H30.html) | text alternative img | A-AAA | error | | ✅ |
| [H32](https://www.w3.org/TR/WCAG20-TECHS/H32.html) | missing form submit button | A-AAA | error | | ✅ |
Expand Down
2 changes: 2 additions & 0 deletions accessibility-rs/src/engine/rules/techniques.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ use strum_macros::IntoStaticStr;
pub enum Techniques {
/// <https://www.w3.org/TR/WCAG20-TECHS/H2>
H2,
/// <https://www.w3.org/TR/WCAG20-TECHS/H24>
H24,
/// <https://www.w3.org/TR/WCAG20-TECHS/H25>
H25,
/// <https://www.w3.org/TR/WCAG20-TECHS/H32.html>
Expand Down
78 changes: 55 additions & 23 deletions accessibility-rs/src/engine/rules/wcag_rule_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,22 +114,22 @@ lazy_static! {
"h1",
"h2",
"h3",
"h4",
"h5",
"h6",
"a",
"button",
"p",
"img",
"span",
"div",
"li",
"ol",
"td",
"th",
"tr",
"textarea",
"select",
"h4",
"h5",
"h6",
"a",
"button",
"p",
"img",
"span",
"div",
"li",
"ol",
"td",
"th",
"tr",
"textarea",
"select",
"input"].contains(&element.value().name()) {
let style = accessibility_tree::style::cascade::style_for_element_ref(
&element,
Expand Down Expand Up @@ -161,13 +161,13 @@ lazy_static! {

if contrast_ratio <= min_contrast {
let message = t!(
&get_message_i18n_str_raw(
&Guideline::Distinguishable,
"",
"3_G18_or_G145.Fail",
""),
locale = auditor.locale,
required = min_contrast.to_string(),
&get_message_i18n_str_raw(
&Guideline::Distinguishable,
"",
"3_G18_or_G145.Fail",
""),
locale = auditor.locale,
required = min_contrast.to_string(),
value = contrast_ratio.to_string());

validation_errors.push(Validation::new_custom_issue(false, "", message).into())
Expand Down Expand Up @@ -529,6 +529,38 @@ lazy_static! {
Validation::new(valid, "", elements, Default::default()).into()
}),
])),
("area",Vec::from([
Rule::new(Techniques::H24.into(), IssueType::Error, Principle::Perceivable, Guideline::TextAlternatives, "1", |nodes,_auditor| {
let mut valid = true;
let mut elements = Vec::new();

for ele in nodes {
let ele = ele.0;
if !has_alt_prop(ele) {
valid = false;
elements.push(get_unique_selector(&ele));
}
}

Validation::new(valid, "ImageMapAreaNoAlt", elements, Default::default()).into()
})
])),
("map",Vec::from([
Rule::new(Techniques::H24.into(), IssueType::Error, Principle::Perceivable, Guideline::TextAlternatives, "1", |nodes,_auditor|{
let mut valid = true;
let mut elements = Vec::new();

for ele in nodes{
let ele = ele.0;
if !has_alt_prop(ele){
valid = false;
elements.push(get_unique_selector(&ele));
}
}

Validation::new(valid,"ImageMapNoAlt",elements, Default::default()).into()
})
])),
("fieldset", Vec::from([
Rule::new(Techniques::H71.into(), IssueType::Error, Principle::Perceivable, Guideline::Adaptable, "1", |nodes, _auditor| {
let mut valid = true;
Expand Down
42 changes: 42 additions & 0 deletions accessibility-rs/tests/unit/area.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
//! Test for anchors.

use accessibility_rs::{engine::audit, AuditConfig};
use maud::html;

#[test]
fn _audit_missing_alt_area() {
//alt attribute missing on first <area> tag
let html = r#"
<img src="workplace.jpg" alt="Workplace" usemap="\#workmap" width="400" height="379">
<map name="workmap" alt="workplace image map" >
<area shape="rect" coords="34,44,270,350" href="computer.htm">
<area shape="rect" coords="290,172,333,250" alt="Phone" href="phone.htm">
<area shape="circle" coords="337,300,44" alt="Cup of coffee" href="coffee.htm">
</map>"#;
let audit: Vec<accessibility_rs::engine::issue::Issue> =
accessibility_rs::audit(AuditConfig::basic(html));

let valid = audit
.iter()
.any(|x| x.message == "1_1_1_H24.ImageMapAreaNoAlt");

assert_eq!(valid, true)
}

#[test]
fn _audit_missing_alt_map() {
// alt attribute missing on <map> tag
let html = r#"
<img src="workplace.jpg" alt="Workplace" usemap="\#workmap" width="400" height="379">
<map name="workmap">
<area shape="rect" coords="34,44,270,350" alt="Computer" href="computer.htm">
<area shape="rect" coords="290,172,333,250" alt="Phone" href="phone.htm">
<area shape="circle" coords="337,300,44" alt="Cup of coffee" href="coffee.htm">
</map>"#;
let audit: Vec<accessibility_rs::engine::issue::Issue> =
accessibility_rs::audit(AuditConfig::basic(html));

let valid = audit.iter().any(|x| x.message == "1_1_1_H24.ImageMapNoAlt");

assert_eq!(valid, true)
}
1 change: 1 addition & 0 deletions accessibility-rs/tests/unit/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ pub mod img;
pub mod input;
pub mod label;
pub mod meta;
pub mod area;
Loading