Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add integrations and examples #203

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

aranw
Copy link
Contributor

@aranw aranw commented Oct 3, 2023

Called the section integrations but I guess this could be named something else maybe?

I added the integrations section as 12 so that I wasn't renumbering everything and then possibly conflicting with other contributions

Closes #50

examples/template/html.templ Outdated Show resolved Hide resolved
examples/template/html_templ.go Outdated Show resolved Hide resolved
@a-h
Copy link
Owner

a-h commented Oct 4, 2023

This looks great, thanks for doing that! Just checking whether you meant to commit one of the files.

@aranw
Copy link
Contributor Author

aranw commented Oct 4, 2023

This looks great, thanks for doing that! Just checking whether you meant to commit one of the files.

Yeah that was a mistake! I've removed it now

@a-h
Copy link
Owner

a-h commented Oct 4, 2023

Thanks a lot!

@a-h a-h merged commit f14d582 into a-h:main Oct 4, 2023
@joerdav
Copy link
Collaborator

joerdav commented Oct 4, 2023

Odd that the PR checks didn't run on this, it looks like the examples were generated with a non-HEAD version of templ.

Maybe we need a contribution guide that says you should run go run ./cmd/templ generate rather than templ generate before commiting.

@aranw aranw deleted the feat/add-integration-docs-examples-3 branch October 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: write up how to use with https://github.com/gin-gonic/gin
3 participants