Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing () in CSS component example #194

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

wdscxsj
Copy link
Contributor

@wdscxsj wdscxsj commented Oct 2, 2023

  • Add missing () for css components.
  • Remove redundant trailing ;.

According to the implementation of RenderCSSItems(), className still works without invocation, but the previous doc follows a theme that () is always good (unless the component is used in other clever ways). I think it's better to keep consistent here, or make it clear in the doc when a factory function is also OK.

Copy link
Owner

@a-h a-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@a-h a-h merged commit fe940bb into a-h:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants