Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate same dev and prod code, fixes #700 #1027

Merged
merged 17 commits into from
Dec 31, 2024
Merged

feat: generate same dev and prod code, fixes #700 #1027

merged 17 commits into from
Dec 31, 2024

Conversation

a-h
Copy link
Owner

@a-h a-h commented Dec 27, 2024

  • first attempt
  • fix event handler
  • fix double quoting
  • it helps to use the right variable name
  • stop double quoting
  • quote again
  • stop quoting, but add quotes
  • use devMode from the CLI flags on the CLI, leave env for runtime
  • fix up watch mode
  • add generated files

@a-h a-h mentioned this pull request Dec 27, 2024
Closed
@a-h a-h marked this pull request as ready for review December 28, 2024 14:07
@a-h a-h mentioned this pull request Dec 28, 2024
Closed
@a-h
Copy link
Owner Author

a-h commented Dec 28, 2024 •
edited
Loading

Closes #700

@a-h a-h requested a review from joerdav December 28, 2024 14:49
@joerdav
Copy link
Collaborator

joerdav commented Dec 28, 2024

And will review this Monday too :)

This was linked to issues Dec 28, 2024
refactor: update dev / watch mode so that it doesn't modify unchanged _templ.go files #700
Closed
failed to cache strings #940
Closed
joerdav
joerdav requested changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@joerdav joerdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This'll make developing templ much easier, no more stop-starting!

I had a couple of comments, nothing major.

watchmode.go Show resolved Hide resolved
watchmode.go Outdated Show resolved Hide resolved
cmd/templ/generatecmd/eventhandler.go Outdated Show resolved Hide resolved
cmd/templ/generatecmd/eventhandler.go Outdated Show resolved Hide resolved
cmd/templ/generatecmd/cmd.go Outdated Show resolved Hide resolved
@a-h a-h requested a review from joerdav December 30, 2024 20:44
@a-h a-h mentioned this pull request Dec 30, 2024
Closed
@joerdav
Copy link
Collaborator

joerdav commented Dec 31, 2024

Nice, all looks great!

@a-h a-h merged commit a66a237 into main Dec 31, 2024
7 checks passed
@a-h a-h deleted the watch_mode_v2 branch December 31, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerdav joerdav joerdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@a-h @joerdav