Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ElliotAlbert
Copy link

Updated the get game log section containing information about special event games

Updated the get game log section containing information about special event games
@ElliotAlbert
Copy link
Author

Let me know if my formatting is a bit off

@Zmalski
Copy link
Owner

Zmalski commented Sep 26, 2024

This is great, thank you! Apologies for the late review, been busy with some personal life matters that came up.

@nathan-probert
Copy link

nathan-probert commented Nov 2, 2024

Do you have a reference or something for this?

It looks like this endpoint now doesn't have gameType 1 at all anymore (example: https://api-web.nhle.com/v1/player/8471675/game-log/20232024/1 - Sidney Crosby : it shows available gameTypes for each season as always 2 or 2 and 3).

This also means the regular season is gameType 2, and playoffs are gameType 3. The Penguins didn't make it to the playoffs the last two years, but did in 2021, which has gameType 3 available.

@ElliotAlbert
Copy link
Author

This could well be deprecated by now, they have been changing this api quite a bit recently, I will have a look on Monday regarding the World Series and similar special events and update when I have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants