Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: logAttempt succeeds if the password is of the first user in the users table #215

Closed
AfzalivE opened this issue Feb 6, 2014 · 1 comment · Fixed by #220
Closed

Comments

@AfzalivE
Copy link
Contributor

AfzalivE commented Feb 6, 2014

Using the UserController supplied with Confide, the do_login function looks like this:

If I use something like TamperMonkey or Postman to submit a form that only has the following field with the corresponding value, no username or email field:

password  = "password_of_the_first_user_in_the_users_table"

It actually logs in. I have verified this on two of my projects. Can anyone confirm this behaviour?

@AfzalivE
Copy link
Contributor Author

AfzalivE commented Feb 8, 2014

So, this was happening because the $identity_columns is empty after array_diff since there are no fields besides password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant