Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Best Score to Score #38

Closed
ZhengLinLei opened this issue Oct 13, 2023 · 3 comments · Fixed by #40 or #45
Closed

Change Best Score to Score #38

ZhengLinLei opened this issue Oct 13, 2023 · 3 comments · Fixed by #40 or #45
Assignees
@ZhengLinLei
Labels
merged Branch merge into dev. Waiting for version

Comments

@ZhengLinLei
Copy link
Owner

The game show the text Best Score although is not the the record score. Change the text to Score.

       <header class="score-tab">
            <h3 class="best">NEW RECORD</h3>
            <h3 class="score">BEST SCORE</h3>
            <div class="color-shape"></div>
        </header>
@ZhengLinLei ZhengLinLei added the pending Waiting to be solved label Oct 13, 2023
@ZhengLinLei
Copy link
Owner Author

The first screen showing Best Score is correct but after playing the game, the text still be shows the same text instead of Score. If the user make new Record the dom will show New Record. So the Best Score will be showed once time.

@ZhengLinLei
Copy link
Owner Author

Branch: fix_task_change_score_text

Hands up if you are fixing it. 🙋‍♀️🙋‍♂️

@ZhengLinLei ZhengLinLei self-assigned this Oct 13, 2023
@ZhengLinLei
Copy link
Owner Author

✅

ZhengLinLei added a commit that referenced this issue Oct 13, 2023
@ZhengLinLei
Best score text changed [#38] & changed things
c06e3d2
@ZhengLinLei ZhengLinLei linked a pull request Oct 13, 2023 that will close this issue
Best score text changed [#38] & changed things #40
Merged
Sankeyr3 added a commit that referenced this issue Oct 13, 2023
@Sankeyr3
Merge pull request #40 from ZhengLinLei/fix_task_change_score_text
d81864a 
Best score text changed [#38] & changed things
@ZhengLinLei ZhengLinLei added merged Branch merge into dev. Waiting for version and removed pending Waiting to be solved labels Oct 13, 2023
@ZhengLinLei ZhengLinLei linked a pull request Oct 15, 2023 that will close this issue
Release v0.1.6 #45
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhengLinLei ZhengLinLei

Labels
merged Branch merge into dev. Waiting for version
Projects
None yet
Milestone
No milestone
1 participant
@ZhengLinLei