Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lints): Fixes Clippy warnings #8723

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore(lints): Fixes Clippy warnings #8723

merged 1 commit into from
Jul 26, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jul 25, 2024 •
edited
Loading

Motivation

New lints added in the latest version of Clippy are causing CI to fail.

Closes #8722.

Solution

  • Manually addressed new Clippy warnings.

Related changes:

  • Removes unused stored test configs.

Tests

Lint job in CI should pass.

Follow-up Work

Rebase PRs off of main.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡ labels Jul 25, 2024
@arya2 arya2 self-assigned this Jul 25, 2024
@arya2 arya2 requested review from a team as code owners July 25, 2024 20:51
@arya2 arya2 requested review from upbqdn and removed request for a team July 25, 2024 20:51
@arya2 arya2 changed the title cleanup(lints): Fixes Clippy warnings chore(lints): Fixes Clippy warnings Jul 25, 2024
@arya2 arya2 requested a review from oxarbitrage July 25, 2024 20:52
@arya2 arya2 mentioned this pull request Jul 25, 2024
Merged
7 tasks
@mergify mergify bot merged commit 6181ebe into main Jul 26, 2024
192 checks passed
@mergify mergify bot deleted the fix-new-clippy-lints branch July 26, 2024 14:29
@oxarbitrage oxarbitrage mentioned this pull request Jul 27, 2024
Merged
7 tasks
@arya2 arya2 mentioned this pull request Aug 1, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees

@arya2 arya2

Labels
C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix new lints in the latest stable version of clippy
2 participants
@arya2 @oxarbitrage