Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(build): Add ECC dependencies documentation #7794

Merged
merged 5 commits into from
Oct 25, 2023
Merged

docs(build): Add ECC dependencies documentation #7794

merged 5 commits into from
Oct 25, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We need to document the process of upgrading ECC dependencies in Zebra.

Close #6532

Solution

Add a page to the zebra book.

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@oxarbitrage oxarbitrage added A-docs Area: Documentation P-Medium ⚡ A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Oct 21, 2023
@oxarbitrage oxarbitrage self-assigned this Oct 21, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner October 21, 2023 17:46
@oxarbitrage oxarbitrage requested review from teor2345 and removed request for a team October 21, 2023 17:46
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 21, 2023
@teor2345 teor2345 added the extra-reviews This PR needs at least 2 reviews to merge label Oct 22, 2023
@teor2345 teor2345 requested a review from arya2 October 22, 2023 22:35
@teor2345
Copy link
Contributor

We're trying a new review process: I do a second review after someone else has done a review. I also don't do reviews on my Mondays.

I picked @arya2 because he did one of these upgrades recently.

arya2
arya2 previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

book/src/dev/ecc-updates.md Outdated Show resolved Hide resolved
book/src/dev/ecc-updates.md Outdated Show resolved Hide resolved
oxarbitrage and others added 2 commits October 23, 2023 16:26
@oxarbitrage @arya2
add cargo deny suggestion to deny.toml section
990d608 
Co-authored-by: Arya <aryasolhi@gmail.com>
@oxarbitrage @arya2
change sententence syntax
4cf4136 
Co-authored-by: Arya <aryasolhi@gmail.com>
arya2
arya2 previously approved these changes Oct 23, 2023
View reviewed changes
@oxarbitrage oxarbitrage mentioned this pull request Oct 24, 2023
Open
@oxarbitrage @teor2345
Apply suggestions from code review
f07a472 
Co-authored-by: teor <teor@riseup.net>
teor2345
teor2345 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Oct 25, 2023
@teor2345
Copy link
Contributor

Two of us have reviewed this, and the latest changes are minor, so I think it's ok to merge.

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Oct 25, 2023
@mergify
Merge of #7794
d44e580
@mergify mergify bot mentioned this pull request Oct 25, 2023
Closed
@mergify mergify bot merged commit c173198 into main Oct 25, 2023
67 checks passed
@mergify mergify bot deleted the issue6532 branch October 25, 2023 03:27
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@arya2 arya2 arya2 left review comments

Assignees

@oxarbitrage oxarbitrage

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the process of updating zcashd dependencies
3 participants
@oxarbitrage @teor2345 @arya2