-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(state): Use different terms for block verification and state queues #7061
Conversation
This PR should be rebased to main after #7035 is merged. I forgot how to set up an automatic rebase. I will add that when i find the feature. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7061 +/- ##
==========================================
- Coverage 77.49% 77.22% -0.28%
==========================================
Files 310 310
Lines 41716 41833 +117
==========================================
- Hits 32329 32304 -25
- Misses 9387 9529 +142 |
…d `Request::CommitCheckpointVerifiedBlock`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for doing this work! I really appreciate it.
The old comments are very confusing, so I made some suggestions where we could make them clearer. I'm also going to ask @arya2 to review as well, because he's more familiar with some parts of this code.
Co-authored-by: teor <teor@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, much clearer, thank you!
Motivation
Close #6681
Solution
Do suggested renames.
Review
Reviewer Checklist
Follow Up Work