Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rc.9] cargo update #6844

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[rc.9] cargo update #6844

merged 1 commit into from
Jun 7, 2023

Conversation

dconnolly
Copy link
Contributor

@dconnolly dconnolly commented Jun 7, 2023

Missed Dependency Updates

Sometimes dependabot misses some dependency updates, or we accidentally turned them off.

Here's how we make sure we got everything:

  • Run cargo update on the latest main branch, and keep the output
  • If needed, update deny.toml
  • Open a separate PR with the changes, and add the output of cargo update to that PR as a comment

Review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?

@dconnolly dconnolly added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Medium ⚡ labels Jun 7, 2023
@dconnolly dconnolly requested a review from a team as a code owner June 7, 2023 02:34
@dconnolly dconnolly requested review from upbqdn and removed request for a team June 7, 2023 02:34
@dconnolly dconnolly added do-not-merge Tells Mergify not to merge this PR and removed C-removed labels Jun 7, 2023
@dconnolly dconnolly mentioned this pull request Jun 7, 2023
41 tasks
@dconnolly dconnolly changed the title [post rc.9] cargo update; remove curve25591-dalek from deny.toml [rc.9] cargo update Jun 7, 2023
@dconnolly dconnolly removed the do-not-merge Tells Mergify not to merge this PR label Jun 7, 2023
@dconnolly dconnolly requested a review from teor2345 June 7, 2023 03:00
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be re-generated after PR #6801 merges, because it removes a lot of outdated dependencies.

PR #6801 is currently in the merge queue.

@teor2345
Copy link
Contributor

teor2345 commented Jun 7, 2023

add the output of cargo update to that PR as a comment

Just a reminder to list the changes the next time you re-generate this PR.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #6844 (a0a89b7) into main (3820637) will decrease coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6844      +/-   ##
==========================================
- Coverage   77.67%   77.52%   -0.16%     
==========================================
  Files         310      310              
  Lines       41418    41416       -2     
==========================================
- Hits        32173    32108      -65     
- Misses       9245     9308      +63     

@teor2345 teor2345 dismissed their stale review June 7, 2023 07:15

The required PR has merged

@dconnolly dconnolly requested review from teor2345, a team, oxarbitrage and arya2 June 7, 2023 18:37
@dconnolly
Copy link
Contributor Author

image

Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending CI

@mergify mergify bot merged commit 8bd5a98 into main Jun 7, 2023
@mergify mergify bot deleted the dependencies branch June 7, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants