Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete outdated TODOs refering to closed issues #6732

Merged
merged 24 commits into from
May 23, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c164cd5
ZIPs were updated to remove ambiguity, this was tracked in #1267.
mpguerra May 19, 2023
9f8161d
#2105 was fixed by #3039 and #2379 was closed by #3069
mpguerra May 19, 2023
39f86f7
#2230 was a duplicate of #2231 which was closed by #2511
mpguerra May 19, 2023
2e362d9
#3235 was obsoleted by #2156 which was fixed by #3505
mpguerra May 19, 2023
9b67e09
#1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixe…
mpguerra May 19, 2023
8ba4367
We migrated to Rust 2021 edition in Jan 2022 with #3332
mpguerra May 19, 2023
725283b
#1631 was closed as not needed
mpguerra May 19, 2023
c141645
#338 was fixed by #3040 and #1162 was fixed by #3067
mpguerra May 19, 2023
2be0331
#2079 was fixed by #2445
mpguerra May 19, 2023
778cce7
#4794 was fixed by #6122
mpguerra May 19, 2023
f1e04dc
#1678 stopped being an issue
mpguerra May 19, 2023
3bdf2cf
#3151 was fixed by #3934
mpguerra May 19, 2023
af3a487
#3204 was closed as not needed
mpguerra May 19, 2023
d3456b8
#1213 was fixed by #4586
mpguerra May 19, 2023
6ed7bca
#1774 was closed as not needed
mpguerra May 19, 2023
b56f858
#4633 was closed as not needed
mpguerra May 19, 2023
da6b1f5
Clarify behaviour of difficulty spacing
mpguerra May 22, 2023
ea15a48
Update comment to reflect implemented behaviour
mpguerra May 22, 2023
d98f55d
Update comment to reflect implemented behaviour when retrying block d…
mpguerra May 22, 2023
14899f3
Update `TODO` to remove closed issue and clarify when we might want t…
mpguerra May 22, 2023
23fdc81
Update `TODO` to remove closed issue and clarify what we might want t…
mpguerra May 22, 2023
7c5d6b6
Clarify benefits of how we do block verification
mpguerra May 22, 2023
f4dcdc0
Fix rustfmt errors
teor2345 May 23, 2023
32d37c7
Merge branch 'main' into pili-6281
teor2345 May 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zebra-chain/src/work/difficulty/tests/vectors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ fn check_testnet_minimum_difficulty_block(height: block::Height) -> Result<(), R
.signed_duration_since(previous_block.header.time);

// zcashd requires a gap that's strictly greater than 6 times the target
// threshold, but ZIP-205 and ZIP-208 are ambiguous. See bug #1276.
// threshold.
match NetworkUpgrade::minimum_difficulty_spacing_for_height(Network::Testnet, height) {
None => Err(eyre!("the minimum difficulty rule is not active"))?,
Some(spacing) if (time_gap <= spacing) => Err(eyre!(
Expand Down
4 changes: 0 additions & 4 deletions zebra-consensus/src/transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -740,10 +740,6 @@ where
orchard_shielded_data,
&shielded_sighash,
)?))

// TODO:
// - verify orchard shielded pool (ZIP-224) (#2105)
// - shielded input and output limits? (#2379)
}

/// Verifies if a V5 `transaction` is supported by `network_upgrade`.
Expand Down
2 changes: 0 additions & 2 deletions zebra-network/src/peer_set/limit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ impl Drop for ConnectionTracker {

// We ignore disconnected errors, because the receiver can be dropped
// before some connections are dropped.
//
// TODO: This channel will be bounded by the connection limit (#1850, #1851, #2902).
let _ = self.close_notification_tx.send(ConnectionClosed);
}
}
1 change: 0 additions & 1 deletion zebra-network/src/peer_set/set.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ where
/// Checks if the minimum peer version has changed, and disconnects from outdated peers.
fn disconnect_from_outdated_peers(&mut self) {
if let Some(minimum_version) = self.minimum_peer_version.changed() {
// TODO: Remove when the code base migrates to Rust 2021 edition (#2709).
let preselected_p2c_peer = &mut self.preselected_p2c_peer;

self.ready_services.retain(|address, peer| {
Expand Down
3 changes: 0 additions & 3 deletions zebra-network/src/policies.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ impl<Req: Clone + std::fmt::Debug, Res, E: std::fmt::Debug> Policy<Req, Res, E>
Some(
// Let other tasks run, so we're more likely to choose a different peer,
// and so that any notfound inv entries win the race to the PeerSet.
//
// TODO: move syncer retries into the PeerSet,
// so we always choose different peers (#3235)
Box::pin(tokio::task::yield_now().map(move |()| retry_outcome)),
)
} else {
Expand Down
1 change: 0 additions & 1 deletion zebra-state/src/service/finalized_state/tests/prop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ fn blocks_with_v5_transactions() -> Result<()> {
);
prop_assert_eq!(Some(height), state.finalized_tip_height());
prop_assert_eq!(hash.unwrap(), block.hash);
// TODO: check that the nullifiers were correctly inserted (#2230)
height = Height(height.0 + 1);
}
});
Expand Down