Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check genesis hash in checkpoint lists #663

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Check genesis hash in checkpoint lists #663

merged 4 commits into from
Jul 16, 2020

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jul 15, 2020 •
edited
Loading

  • add initial consensus parameter module (Tracking: all the consensus parameters #565)
  • add the Network to CheckpointVerifier and CheckpointList
  • check the genesis hash in checkpoint lists
  • get the genesis previous block hash from the consensus parameters

@teor2345 teor2345 added Poll::Ready A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code labels Jul 15, 2020
@teor2345 teor2345 requested a review from a team July 15, 2020 09:59
@teor2345 teor2345 self-assigned this Jul 15, 2020
@teor2345 teor2345 marked this pull request as draft July 15, 2020 10:00
@teor2345
Copy link
Contributor Author

Oops, this should be draft until #639 merges, then I'll rebase.

@teor2345 teor2345 mentioned this pull request Jul 15, 2020
Closed
18 tasks
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #663 into main will increase coverage by 3.83%.
The diff coverage is 76.15%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   57.95%   61.78%   +3.83%     
==========================================
  Files          91      103      +12     
  Lines        4419     5163     +744     
==========================================
+ Hits         2561     3190     +629     
- Misses       1858     1973     +115

@teor2345
Copy link
Contributor Author

I force-pushed to pick up the merge in #639, which was needed to resolve a merge conflict with main.

@teor2345
Copy link
Contributor Author

Ok, now we're based on main, and ready to review.

@teor2345 teor2345 marked this pull request as ready for review July 16, 2020 05:12
@teor2345 teor2345 mentioned this pull request Jul 16, 2020
Merged
2 tasks
hdevalence
hdevalence approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdevalence hdevalence merged commit c13907d into ZcashFoundation:main Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

Assignees

@teor2345 teor2345

Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code
Projects
None yet
Milestone
Block Validation
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @hdevalence