change(deps): Upgrade shared dependencies to match zcashd 5.5.0
#6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```sh cargo upgrade --workspace << EOF bellman bls12_381 group halo2 halo2_proofs jubjub orchard redjubjub zcash_address zcash_note_encryption zcash_primitives zcash_proofs EOF ```
This reverts commit 4d4accc.
|
Temporary network error building the
https://github.com/ZcashFoundation/zebra/actions/runs/4728149718/jobs/8389421342#step:11:786 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6536 +/- ##
==========================================
+ Coverage 77.68% 77.80% +0.12%
==========================================
Files 305 305
Lines 40104 40104
==========================================
+ Hits 31154 31204 +50
+ Misses 8950 8900 -50 |
arya2
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use the same shared dependencies as the latest
zcashdversion 5.5.0.Closes #6232
Specifications
These libraries already implement the consensus rules as specified.
Solution
Dependencies
Upgrade the following shared dependencies:
Remove redundant
deny.tomlentriesCode Changes
Replace orchard::from_bytes_wide() with ff::from_uniform_bytes()
Review
This is an urgent change we want in the next release, so we continue building with Rust 1.69.
Reviewer Checklist
Follow Up Work
Upgrade zcash_script:
zcash_scriptafter thezcashd5.5.0 release #6535