Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ZIP-401 mempool cost thresholds for Orchard transactions #6521

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

This PR changes Zebra's mempool cost thresholds to match zcashd 5.5.0, as specified in the latest ZIP-401 update:
https://github.com/zcash/zips/pull/685/files#diff-e8ce48f91a8494325daeea2a8bfb2f5a4f1d6d261d0c3a985da463b03a24e14cR82

This is a standard rule, so it is not consensus-critical.

Solution

Update the mempool cost threshold constants to match ZIP-401 and zcashd

Review

This is a routine change.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks P-Medium ⚡ A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-mempool Area: Memory pool transactions labels Apr 16, 2023
@teor2345 teor2345 requested a review from a team as a code owner April 16, 2023 23:13
@teor2345 teor2345 self-assigned this Apr 16, 2023
@teor2345 teor2345 requested review from arya2 and removed request for a team April 16, 2023 23:13
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #6521 (0da6b5f) into main (2e434b0) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6521      +/-   ##
==========================================
- Coverage   77.68%   77.59%   -0.09%     
==========================================
  Files         305      305              
  Lines       40104    40104              
==========================================
- Hits        31154    31119      -35     
- Misses       8950     8985      +35     

arya2
arya2 previously approved these changes Apr 17, 2023
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

(Please add updating the comment to follow-up work if this merges as-is)

mergify bot added a commit that referenced this pull request Apr 18, 2023
@mergify mergify bot merged commit f2133c9 into main Apr 18, 2023
@mergify mergify bot deleted the orchard-zip-401 branch April 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-mempool Area: Memory pool transactions C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants