-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase ZIP-401 mempool cost thresholds for Orchard transactions #6521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6521 +/- ##
==========================================
- Coverage 77.68% 77.59% -0.09%
==========================================
Files 305 305
Lines 40104 40104
==========================================
- Hits 31154 31119 -35
- Misses 8950 8985 +35 |
daira
reviewed
Apr 17, 2023
arya2
previously approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you!
(Please add updating the comment to follow-up work if this merges as-is)
8911391
to
0da6b5f
Compare
arya2
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compatibility
Area: Compatibility with other nodes or wallets, or standard rules
A-mempool
Area: Memory pool transactions
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR changes Zebra's mempool cost thresholds to match
zcashd
5.5.0, as specified in the latest ZIP-401 update:https://github.com/zcash/zips/pull/685/files#diff-e8ce48f91a8494325daeea2a8bfb2f5a4f1d6d261d0c3a985da463b03a24e14cR82
This is a standard rule, so it is not consensus-critical.
Solution
Update the mempool cost threshold constants to match ZIP-401 and
zcashd
Review
This is a routine change.
Reviewer Checklist