Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump serde_json from 1.0.94 to 1.0.95 #6425

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 28, 2023

Bumps serde_json from 1.0.94 to 1.0.95.

Release notes

Sourced from serde_json's releases.

v1.0.95

  • Preserve f32 precision when serializing f32 -> serde_json::Value -> JSON string in "arbitrary_precision" mode (#1004, #1005)
Commits
  • 4ea38c4 Release 1.0.95
  • 731886c Merge pull request #1005 from dtolnay/f32cast
  • c9bff92 Fix PartialEq between Value and f32
  • 06f3443 Eliminate f32-to-f64 casting in arbitrary_precision mode
  • b0990a5 Add regression test for issue 1004
  • 02e5833 Update fuzz crate gitignore to ignore coverage dir
  • 4b96996 No longer test so many old compiler versions
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 28, 2023 15:58
@dependabot dependabot bot requested review from arya2 and removed request for a team March 28, 2023 15:58
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #6425 (d4d8666) into main (a38d6c6) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6425      +/-   ##
==========================================
- Coverage   77.81%   77.66%   -0.15%     
==========================================
  Files         304      304              
  Lines       39583    39583              
==========================================
- Hits        30801    30742      -59     
- Misses       8782     8841      +59     

@teor2345
Copy link
Contributor

teor2345 commented Mar 28, 2023

Seems like a temporary failure, but it's the second one I've seen this week:

https://github.com/ZcashFoundation/zebra/actions/runs/4545149509/jobs/8012086496?pr=6425#step:6:48

ERROR: (gcloud.compute.images.list) There was a problem refreshing your current auth tokens: ('Unable to retrieve Identity Pool subject token', '{ "message": "GitHub Actions is temporarily unavailable. Please visit https://www.githubstatus.com/ for the status of our services.", "ref": "Ref A: E7595F9BEDDA4F71B8688E0E1E11C7B8 Ref B: SN1EDGE1616 Ref C: 2023-03-28T15:59:22Z" }')

teor2345
teor2345 previously approved these changes Mar 28, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that are behind an optional feature we don't use.

mergify bot added a commit that referenced this pull request Mar 29, 2023
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.94 to 1.0.95.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.94...v1.0.95)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/serde_json-1.0.95 branch from fe5ca8e to 12c931d Compare March 29, 2023 01:52
@teor2345
Copy link
Contributor

CI on this PR needs to be re-run after PR #6430 merges.

@arya2
Copy link
Contributor

arya2 commented Mar 29, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor

The tip update "Create image from state disk" step failed with:

ERROR: (gcloud.compute.images.create) Could not fetch resource:

  • Internal error. Please try again or contact Google Support. (Code: '5F8116D4523F4.5B322C0.600B2827')

https://github.com/ZcashFoundation/zebra/actions/runs/4558409128/jobs/8041507066?pr=6425#step:13:85

If merging fails due to this, we should just be able to re-run that single failed job.

mergify bot added a commit that referenced this pull request Mar 30, 2023
mergify bot added a commit that referenced this pull request Mar 30, 2023
@mergify mergify bot merged commit 5a901a7 into main Mar 30, 2023
@mergify mergify bot deleted the dependabot/cargo/serde_json-1.0.95 branch March 30, 2023 02:13
@arya2 arya2 mentioned this pull request Apr 18, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants