Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): Add missing continuous deployment step to the release checklist #6401

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix(release): Add missing continuous deployment step to the release checklist #6401

merged 1 commit into from
Mar 27, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

We're missing a release step: we should wait for the continuous deployment to start its machines, so we know the release works.

Review

This is a low priority release checklist change.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?

@teor2345 teor2345 added A-docs Area: Documentation A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Mar 24, 2023
@teor2345 teor2345 requested a review from a team as a code owner March 24, 2023 03:53
@teor2345 teor2345 self-assigned this Mar 24, 2023
@teor2345 teor2345 requested review from upbqdn and removed request for a team March 24, 2023 03:53
@github-actions github-actions bot added C-bug Category: This is a bug C-feature Category: New features labels Mar 24, 2023
mergify bot added a commit that referenced this pull request Mar 27, 2023
@mergify
Merge of #6401
811b1dc
@mergify mergify bot mentioned this pull request Mar 27, 2023
Closed
@mergify mergify bot merged commit 9a3c88c into main Mar 27, 2023
@mergify mergify bot deleted the release-checklist-cd branch March 27, 2023 22:45
@arya2 arya2 mentioned this pull request Apr 18, 2023
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation C-bug Category: This is a bug C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @arya2