Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): Drop Firo cryptocurrency nodes from Zebra's address book, because they are not compatible with Zcash #6398

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 23, 2023

Motivation

Firo is a network that uses the same network magic values as Zcash, but it's not actually compatible with Zcash. This means that our address book can get full of invalid nodes, and we can waste a lot of resources connecting to them.

Just like we did for Flux, we can drop nodes with the default Firo ports from our address book.

Complex Code or Requirements

This is existing code that just needs some extra ports added to it.

Solution

  • Add the default Firo main, test, and dev network ports to our invalid ports list

Review

This is a medium priority network efficiency/security fix.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug P-Medium ⚡ C-security Category: Security issues I-heavy Problems with excessive memory, disk, or CPU usage I-slow Problems with performance or responsiveness A-network Area: Network protocol updates or fixes labels Mar 23, 2023
@teor2345 teor2345 requested a review from a team as a code owner March 23, 2023 23:37
@teor2345 teor2345 self-assigned this Mar 23, 2023
@teor2345 teor2345 requested review from arya2 and removed request for a team March 23, 2023 23:37
@github-actions github-actions bot added the C-feature Category: New features label Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #6398 (03e0c27) into main (fc32e68) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6398      +/-   ##
==========================================
+ Coverage   77.71%   77.75%   +0.03%     
==========================================
  Files         304      304              
  Lines       39583    39583              
==========================================
+ Hits        30761    30776      +15     
+ Misses       8822     8807      -15     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug C-feature Category: New features C-security Category: Security issues I-heavy Problems with excessive memory, disk, or CPU usage I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants