Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nullifier types #568

Merged
merged 5 commits into from
Jul 2, 2020
Merged

add nullifier types #568

merged 5 commits into from
Jul 2, 2020

Conversation

yaahc
Copy link
Contributor

@yaahc yaahc commented Jun 30, 2020

closes #287
closes #288

@yaahc yaahc requested a review from a team June 30, 2020 21:25
dconnolly
dconnolly suggested changes Jun 30, 2020
View reviewed changes
yaahc and others added 2 commits June 30, 2020 14:45
@yaahc @dconnolly
Apply suggestions from code review
1184a25 
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
@yaahc
add zcash_deserialize impls
0986ae0
@yaahc yaahc requested a review from dconnolly June 30, 2020 21:51
dconnolly
dconnolly previously approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@dconnolly dconnolly added this to the Validate transactions. milestone Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #568 into main will increase coverage by 1.17%.
The diff coverage is 55.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   53.05%   54.22%   +1.17%     
==========================================
  Files          68       89      +21     
  Lines        3212     3963     +751     
==========================================
+ Hits         1704     2149     +445     
- Misses       1508     1814     +306
Impacted Files Coverage Δ
tower-batch/src/error.rs 0.00% <0.00%> (ø)
tower-batch/src/layer.rs 0.00% <0.00%> (ø)
zebra-chain/src/block.rs 87.50% <ø> (+16.53%) ⬆️
zebra-chain/src/keys/sapling.rs 85.30% <ø> (ø)
zebra-chain/src/lib.rs 50.00% <ø> (ø)
zebra-chain/src/merkle_tree.rs 0.00% <ø> (ø)
zebra-chain/src/note_commitment_tree.rs 0.00% <ø> (ø)
zebra-chain/src/serde_helpers.rs 0.00% <0.00%> (ø)
zebra-chain/src/transaction.rs 16.66% <ø> (+16.66%) ⬆️
zebra-chain/src/transaction/joinsplit.rs 100.00% <ø> (+4.91%) ⬆️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f6ce8...683bed0. Read the comment docs.

@yaahc yaahc requested review from dconnolly and a team July 1, 2020 21:59
dconnolly
dconnolly approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@yaahc yaahc merged commit 00e7506 into main Jul 2, 2020
@yaahc yaahc deleted the nullifier branch July 2, 2020 00:57
dconnolly added a commit that referenced this pull request Jul 3, 2020
@yaahc @dconnolly
add nullifier types (#568)
d6aa0ae 
* add nullifier types

* Apply suggestions from code review

Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>

* add zcash_deserialize impls

* Add docs

Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Transaction Validation
Development

Successfully merging this pull request may close these issues.

Sapling Nullifier Sprout Nullifier
2 participants
@yaahc @dconnolly