Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Stop using multiple jobs for quick Google Cloud tests #5560

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 7, 2022

Motivation

This PR only uses multiple CI jobs for the full sync tests.
All the other test run in a single "Run" job.

If the SSH errors in these tickets are related to the number of ssh connections we make, this should reduce our CI error rates due to:

But it doesn't actually fix these bugs. (Unless the cause is an undocumented Google Cloud inbound SSH connection rate-limit.)

Solution

  • Add a new parameter for long tests, and only enable it for the full sync test
  • Remove a job that's a duplicate of the "Run" job
  • Remove unused steps and whitespace

Review

@gustavovalverde might be the best person to review this PR.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures labels Nov 7, 2022
@teor2345 teor2345 self-assigned this Nov 7, 2022
@teor2345 teor2345 requested a review from a team as a code owner November 7, 2022 00:30
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team November 7, 2022 00:30
@teor2345 teor2345 changed the title fix(ci): Stop using multiple jobs for quick tests fix(ci): Stop using multiple jobs for quick Google Cloud tests Nov 7, 2022
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 7, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Nov 7, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

teor2345 commented Nov 7, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Nov 7, 2022
@mergify mergify bot merged commit f94231f into main Nov 7, 2022
@mergify mergify bot deleted the ci-skip-multi-job branch November 7, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants