-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Stop using multiple jobs for quick Google Cloud tests #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio update |
✅ Branch has been successfully updated |
2394c80
to
3473d66
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
dconnolly
approved these changes
Nov 7, 2022
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-bug
Category: This is a bug
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-integration-fail
Continuous integration fails, including build and test failures
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR only uses multiple CI jobs for the full sync tests.
All the other test run in a single "Run" job.
If the SSH errors in these tickets are related to the number of
ssh
connections we make, this should reduce our CI error rates due to:But it doesn't actually fix these bugs. (Unless the cause is an undocumented Google Cloud inbound SSH connection rate-limit.)
Solution
Review
@gustavovalverde might be the best person to review this PR.
Reviewer Checklist