suggestion for introduce getblocktemplate-rpcs feature
#5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
oxarbitrage
reviewed
Oct 18, 2022
I thought it might be difficult to add the mempool but then I tried adding everything except the |
oxarbitrage
approved these changes
Oct 18, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
* introduce `getblocktemplate-rpcs` feature * reorder imports * highlight the problem * add docs * add additional empty state test * add snapshot test * remove getblocktemplate trait * use `cfg-if` * leave server as it was * add a missing space to the docs * fix typo in test Co-authored-by: Arya <aryasolhi@gmail.com> * suggestion for introduce `getblocktemplate-rpcs` feature (#5418) * adds minimal new object for the get block template methods * updated TODO comment Co-authored-by: Arya <aryasolhi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a suggestion (or potential follow-up) for PR #5357 - we could add a new RPC trait with just the field that's currently being used and easily add all of the rest of the fields as they become necessary.
Review
@oxarbitrage can review & merge or close this PR.