fix(release): Fix the config for release-drafter
#5275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release-drafterrelease-drafter
teor2345
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #5203 introduced an erroneous config for https://github.com/marketplace/actions/release-drafter. The error is reported in this output https://github.com/ZcashFoundation/zebra/actions/runs/3135690088/jobs/5091669854. It seems to be related to
version-resolver.major.labels.Solution
This PR specifies the value for the key
labelsinversion-resolver.majorto be a list with the empty string.Review
The reason why this bug went to
mainin the first place is that there's probably no way to test the config before merging it tomain. I think the same applies to this fix. I assume we'll see if it works after we merge it.Reviewer Checklist