Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): prints git metadata and platform info when zebrad starts up #5200

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Sep 19, 2022

Motivation

To make it easier for user to find git metadata and platform info for their bug reports.

Closes #3111

Solution

Logs the panic metadata at info level when starting a zebrad server

Review

Anyone can review this PR

Reviewer Checklist

  • Logs git and build metadata when running zebrad start or copy-state commands

@arya2 arya2 requested a review from a team as a code owner September 19, 2022 22:35
@arya2 arya2 requested review from upbqdn and removed request for a team September 19, 2022 22:35
@arya2 arya2 changed the title feat(logs) prints git metadata and platform info when zebrad starts up feat(logs): prints git metadata and platform info when zebrad starts up Sep 19, 2022
@teor2345
Copy link
Contributor

Would you mind showing us what the output looks like in the logs?

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #5200 (eae5002) into main (202dc43) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5200      +/-   ##
==========================================
- Coverage   79.14%   79.09%   -0.06%     
==========================================
  Files         307      307              
  Lines       39218    39224       +6     
==========================================
- Hits        31040    31023      -17     
- Misses       8178     8201      +23     

@arya2
Copy link
Contributor Author

arya2 commented Sep 20, 2022

Would you mind showing us what the output looks like in the logs?

Looks like

2022-09-20T16:04:29.201116Z  INFO zebrad::components::tracing::component: started tracing component filter="info" TRACING_STATIC_MAX_LEVEL=LevelFilter::TRACE LOG_STATIC_MAX_LEVEL=Trace
2022-09-20T16:04:29.201524Z  INFO zebrad::application: Diagnostic Metadata:
version: 1.0.0-unofficial-test.4+30.geae5002
Zcash network: Mainnet
state version: 25
branch: log-git-metadata-on-start
git commit: eae5002
commit timestamp: 2022-09-20T15:59:47Z
target triple: x86_64-unknown-linux-gnu
build profile: debug

@teor2345 teor2345 added the C-enhancement Category: This is an improvement label Sep 20, 2022
@teor2345
Copy link
Contributor

Would you mind showing us what the output looks like in the logs?

Looks like

Looks great!

@teor2345
Copy link
Contributor

Would you mind using GitHub keywords to link issues and PRs?
GitHub automatically closes the issue when the PR closes, but ZenHub doesn't.

I usually put:
Closes #3111
in the PR description. (Adding it to comments doesn't work.)

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Co-authored-by: teor <teor@riseup.net>
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mergify bot added a commit that referenced this pull request Sep 20, 2022
@mergify mergify bot merged commit 6343b83 into main Sep 20, 2022
@mergify mergify bot deleted the log-git-metadata-on-start branch September 20, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log git metadata and platform info when zebrad starts up
3 participants